[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: emacs-dynamic-module in Emacs Git?

From: Aurélien Aptel
Subject: Re: emacs-dynamic-module in Emacs Git?
Date: Thu, 27 Nov 2014 16:38:48 +0100

On Thu, Nov 27, 2014 at 3:10 AM, Ted Zlatanov <address@hidden> wrote:
> On Wed, 26 Nov 2014 18:05:55 +0100 Aurélien Aptel <address@hidden> wrote:
> AA> On Tue, Nov 25, 2014 at 11:05 AM, Ted Zlatanov <address@hidden> wrote:
>>> Push it to your Github repo
>>> https://github.com/aaptel/emacs-dynamic-module so it can be reviewed.  We
>>> will try to get to it quickly and merge it with the necessary ifdefs, if
>>> you don't have them.
> AA> I've force-pushed on my repo. The branch is "dynamic-modules". It
> AA> should already be properly ifdef'd and turned off by default. You can
> AA> turn it on via the configure script with --with-ltdl.
> I've pushed your dynamic-modules branch (rebased against today's master
> branch) to the dynamic-modules branch on the Emacs repo for review and
> testing. Please use that in your repo as well.

Will do.

> There are just a few issues, none major:
> * two XXX comments

Well, it's still experimental code, what's bothering you?

> * the ChangeLog entries need rewriting (I would squash to a single
>   commit anyway, if that's OK with you, which would make the above
>   rebasing note irrelevant)

I didn't write any changelog entries. Are you talking about commit
messages? Not everything in there is relevant to the ChangeLog file
and some might be obsolete.

> * no documentation (NEWS, ELisp manual, etc.)
> For me only the first one is a blocker. The documentation is also
> important--at least mention how to use this new facility in a text file
> please. We can try to write it if you're unable, but it would be good to
> give us a first draft at least.

Sure. Where should I write this documentation? I can reuse what I
wrote in my announcement [1].

1: https://lists.gnu.org/archive/html/emacs-devel/2014-10/msg00292.html

reply via email to

[Prev in Thread] Current Thread [Next in Thread]