[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] master e820f16: Added file-tree-walk to files.el.

From: Eric S. Raymond
Subject: Re: [Emacs-diffs] master e820f16: Added file-tree-walk to files.el.
Date: Wed, 3 Dec 2014 14:53:58 -0500
User-agent: Mutt/1.5.21 (2010-09-15)

David Engster <address@hidden>:
> Stefan Monnier writes:
> >> +before descending into it, and if nil is returned at that point
> >> +the descent will be prevented.  Directory entries are sorted with
> >> +string-lessp"
> >              ^^^
> > Don't forget to punctuate your docstrings.
> And string-lessp should be quoted, but it doesn't matter since AFAICS
> that sentence isn't true anyway.

Huh?  They're from directory-files, which according to its documentation
sorts the names with string-lessp.
> Apart from that, I find this function confusing. Why not simply call
> ACTION with the full filename instead of splitting in into DIR and the
> filename sans the directory part (where the latter might actually be a
> subdirectory)?

Because that's how the well-tested code I found in the EmacsWiki 
cookbook section worked.
                <a href="http://www.catb.org/~esr/";>Eric S. Raymond</a>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]