Re: [Emacs-diffs] master e820f16: Added file-tree-walk to files.el.

[David Engster]

Eric S. Raymond writes:
> David Engster <address@hidden>:
>> Stefan Monnier writes:
>> >> +before descending into it, and if nil is returned at that point
>> >> +the descent will be prevented.  Directory entries are sorted with
>> >> +string-lessp"
>> >              ^^^
>> > Don't forget to punctuate your docstrings.
>> 
>> And string-lessp should be quoted, but it doesn't matter since AFAICS
>> that sentence isn't true anyway.
>
> Huh?  They're from directory-files, which according to its documentation
> sorts the names with string-lessp.

Yes, unless you set NOSORT.

>> Apart from that, I find this function confusing. Why not simply call
>> ACTION with the full filename instead of splitting in into DIR and the
>> filename sans the directory part (where the latter might actually be a
>> subdirectory)?
>
> Because that's how the well-tested code I found in the EmacsWiki 
> cookbook section worked.

Oh, I didn't know it was from the EmacsWiki. Please forget I said
something.

-David