[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Generalize start-process with keyword args

From: Eli Zaretskii
Subject: Re: [PATCH] Generalize start-process with keyword args
Date: Tue, 17 Mar 2015 09:50:09 +0200

> From: Daiki Ueno <address@hidden>
> Date: Tue, 17 Mar 2015 11:16:49 +0900
> Cc: address@hidden
> address@hidden :command @var{command}
> +Use @var{command} as the command line of the process.  @var{command}
> +is a list starting with the program name, followed by strings to give
> +to program as arguments.

I think it'd be good to clearly state here that "the program name" is
actually the name of the program's executable file.

> address@hidden :coding @var{coding}
> +Use @var{coding} as the coding system for this process.  To specify
> +different coding systems for decoding data from the connection and for
> +encoding data sent to it, specify @code{(@var{decoding} .
> address@hidden)} for @var{coding}.

FWIW, I like the doc string's wording better:

  If @var{coding} is a symbol, it specifies the coding system to be
  used for both reading and writing of data from and to the
  connection.  If @var{coding} is a cons cell
  @address@hidden(@var{decoding} . @var{encoding})}}, then @var{decoding}
  will be used for reading and @var{encoding} for writing.

> +If you don't specify this keyword at all, the default
> +is to determine the coding systems from the data.

Please mention 'undecided' explicitly here, since that is more
specific than the more vague "determine from the data".


reply via email to

[Prev in Thread] Current Thread [Next in Thread]