[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Generalize start-process with keyword args

From: Stefan Monnier
Subject: Re: [PATCH] Generalize start-process with keyword args
Date: Wed, 18 Mar 2015 09:03:19 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux)

> I tend to agree with Stefan, as I find no documentation about the
> implication of no-conversion for ":coding nil" except in the C source
> code.  Maybe we could add the exception back if it turns out to be too
> confusing.

We should probably also declare that uses of nil in other similar
circumstances is deprecated (I actually don't know where are those
places where nil means "binary").

> +If @var{coding} is @code{nil}, the coding system chosen for decoding
> +output is @code{undecided}, meaning deduce the encoding from the
> +actual data.

Doesn't it also depend on coding-system-for-read and coding-system-for-write?

> +  tem = Fplist_get (contact, QCconnection_type);
> +  if (!NILP (tem))
> +    {
> +      if (EQ (tem, Qpty))
> +     XPROCESS (proc)->pty_flag = 1;
> +      else if (EQ (tem, Qpipe))
> +     XPROCESS (proc)->pty_flag = 0;

Please use `true' and `false' instead of 0 and 1.

> +      else
> +     report_file_error ("Unknown connection type", tem);
> +    }
> +  else
> +    XPROCESS (proc)->pty_flag = !NILP (Vprocess_connection_type);

Any reason why you nested the "if/elseif/else" inside the outer "if"
instead of having a 4-way "if/elseif/elseif/else"?
[ Either way is fine by me, I'm just being curious here.  ]


reply via email to

[Prev in Thread] Current Thread [Next in Thread]