[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] master f469024: Use delete-char instead of delete-back

From: Stefan Monnier
Subject: Re: [Emacs-diffs] master f469024: Use delete-char instead of delete-backward-char.
Date: Thu, 19 Mar 2015 16:04:59 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux)

> -     * lisp/leim/quail/hangul.el
> -     * lisp/progmodes/cperl-mode.el: Use delete-char instead of
> +     * lisp/leim/quail/hangul.el (hangul-delete-backward-char)
> +     (hangul-to-hanja-conversion):
> +     * lisp/progmodes/cperl-mode.el (cperl-electric-keyword)
> +     (cperl-electric-backspace): Use delete-char instead of
>       delete-backward-char, fixes compilation warnings.

Looks good, thanks.

> -     (delete-char (- arg))))))
> +     (call-interactively 'delete-backward-char)))))
FWIW, my suggestion to use call-interactively was just that:
a suggestion.  I don't know this cperl's command well enough to know
what should ideally be done.  It might even be that using delete-char
really is The Right Thing.  Noone can know which is right before he/she
looks at the function in enough detail to know how&when the various
alternatives will behave differently (after which it's generally easy
to figure out which one is best).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]