[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] master 0679159: Use the VC root in `log-edit-listfun'

From: Stefan Monnier
Subject: Re: [Emacs-diffs] master 0679159: Use the VC root in `log-edit-listfun'
Date: Fri, 10 Apr 2015 02:33:47 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux)

>> +                   ;; FIXME: Should expand the list for directories.
>> +                   ;; Is the above still relevant?  If so, it needs a
>> +                   ;; better explanation. -- dgutov
> I think that for the use case in Emacs's master it is not really
> relevant any more because there's only a single ChangeLog.

Actually, no: it is still relevant.

> The problem was as follows:
> - mark "." in vc-dir then do C-x v v to commit changes to a few lisp files.
> - be disappointed that the log-edit buffer was not pre-filled with the
>   corresponding entries in lisp/ChangeLog because lisp/ChangeLog is not
>   the right file for "." and log-edit doesn't know that the files that
>   will be committed are somewhere underneath the `lisp' subdirectory.

The remaining problem is that when marking ".", log-edit may find the
right ./ChangeLog file but without knowing which files in "." will be
committed, it can't know which entries to select.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]