[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] master 0679159: Use the VC root in `log-edit-listfun'

From: Dmitry Gutov
Subject: Re: [Emacs-diffs] master 0679159: Use the VC root in `log-edit-listfun'
Date: Sat, 11 Apr 2015 07:11:23 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:36.0) Gecko/20100101 Thunderbird/36.0

On 04/10/2015 09:33 AM, Stefan Monnier wrote:

The remaining problem is that when marking ".", log-edit may find the
right ./ChangeLog file but without knowing which files in "." will be
committed, it can't know which entries to select.

Actually, it ends up working for "." because `log-edit-changelog-entries' tries to fall back to "just look for FILE" if it doesn't find exact matches, and then does (setq pattern (file-name-nondirectory "./")), which is an empty string. No such luck for any subdirectory.

I think I've fixed that now, but `log-edit-changelog-insert-entries' replacement logic for relative paths won't in general work for these directory entries. Also not a problem for Emacs master.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]