[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: etags test is broken on MS-Windows

From: Paul Eggert
Subject: Re: etags test is broken on MS-Windows
Date: Tue, 19 May 2015 10:57:57 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0

On 05/19/2015 08:27 AM, Eli Zaretskii wrote:
I think it's due to DOS CR-LF EOL format of some files in the test suite.

You're right, I misdiagnosed the porting problem.  Sorry about that.

If we agree that the problem is due to EOL format, we could try thinking about a solution. The root cause for the problem is that on Windows, etags accounts for the stripped CR characters, while on Unix it treats them as part of the contents, so the byte counts are offset by the number of the preceding lines.

That sounds like a problem, but not a problem that the test case is trying to detect. A simple way that should cajole the tests into passing is to remove the trailing CRs from the test data, so I installed a patch to do that. If we ever want to make ctags output portable among Unix vs DOS conventions we can bring back test cases involving CRs.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]