[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: etags test is broken on MS-Windows
From: |
Eli Zaretskii |
Subject: |
Re: etags test is broken on MS-Windows |
Date: |
Sat, 23 May 2015 11:46:23 +0300 |
> Date: Thu, 21 May 2015 19:49:22 +0300
> From: Eli Zaretskii <address@hidden>
> Cc: address@hidden, address@hidden
>
> > >Now, these 3 files have exactly identical contents, and the _only_
> > >difference between the first 2 and the 3rd is that the latter is
> > >gzip-compressed. So that should be the only reason why all its line
> > >counts are off by 1, and its byte counts are all off by 73, which just
> > >happens to be the length of the first line of the (uncompressed) file.
> >
> > This is a bug.
> >
> > >So could it be that rewinding a 'popen'-created stream doesn't work
> > >correctly on GNU/Linux as well? If so, we will have to make changes
> > >in etags to not do that, I think, and instead reuse the already-read
> > >stuff as needed.
> >
> > It could well be. It may have happened that, when I checked that the
> > TAGS files were the same, I just looked at them without running diff and
> > I missed this discrepancy.
>
> After thinking a bit about the alternative solution, I concluded that
> the simplest will be to decompress to a temporary file and read from
> there. Does the patch below look OK? Or can someone think about a
> more elegant way of solving this?
No comments, so I pushed these changes.
- Re: etags test is broken on MS-Windows, Eli Zaretskii, 2015/05/19
- Re: etags test is broken on MS-Windows, Francesco Potortì, 2015/05/21
- Re: etags test is broken on MS-Windows, Eli Zaretskii, 2015/05/21
- Re: etags test is broken on MS-Windows, Paul Eggert, 2015/05/21
- Re: etags test is broken on MS-Windows, Eli Zaretskii, 2015/05/21
- Re: etags test is broken on MS-Windows, Paul Eggert, 2015/05/21
- Re: etags test is broken on MS-Windows, Eli Zaretskii, 2015/05/21
- Re: etags test is broken on MS-Windows, Paul Eggert, 2015/05/21
- Re: etags test is broken on MS-Windows, Eli Zaretskii, 2015/05/22
- Re: etags test is broken on MS-Windows, Francesco Potortì, 2015/05/22
- Re: etags test is broken on MS-Windows, Eli Zaretskii, 2015/05/22