[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 397e316: Add option `calendar-weekend-days'

From: Ingo Lohmar
Subject: Re: master 397e316: Add option `calendar-weekend-days'
Date: Tue, 04 Aug 2015 18:01:19 +0200
User-agent: Notmuch/0.19+110~gb2cc2a6 (http://notmuchmail.org) Emacs/ (x86_64-unknown-linux-gnu)

On Tue, Aug 04 2015 11:43 (-0400), Glenn Morris wrote:

> It's no problem, don't worry about it.
> Adding a missing commit message to a later commit, like in 4e1bdd44,
> where you added a commit log for lisp/calendar/calendar.el, which wasn't
> changed at all in that change, isn't the right way to correct things
> though. It just causes confusion when reading the git log, and now there
> will be three entries for this change in the generated ChangeLog. What
> you are supposed to do is (from admin/notes/repo) run 'make
> change-history' (or wait till Sunday when that happens automatically),
> then edit ChangeLog.2 to correct it and commit it. Feel free to correct
> any of the docs if there was something that would have made this stuff
> clearer to you. (You're not the first person to edit ChangeLog.2 by hand.)
> Wrt doc/emacs/calendar.texi, you're missing a final ".". at the end of
> the sentence you added. (I'm not sure this was worth adding, since the
> header faces aren't even mentioned in the manual. Not everything needs
> to be. Which calendar systems even have something other than two
> consecutive weekend days?)

Alright, thanks again.  I have read up on this and will try to fix the
changelog now.

But first, I am first going to fix the doc (I also was hesitant to
mention it at all, but figured that a single sentence at precisely that
place could be helpful).

As for the rationale: It's not about anything other than two consecutive
days, actually.  But, eg, in Israel, Friday(!) and Saturday are weekend
days.  And in general, weekend days cannot be deduced from the start of
the week: Both the US and Europe have Sat/Sun weekends, but in the US,
the week AFAIK conventionally starts on Sun, while in Europe, it starts
on Mon.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]