[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] master c13a4df: Remove the calls to `seq-into` from `s
|
From: |
Nicolas Petton |
|
Subject: |
Re: [Emacs-diffs] master c13a4df: Remove the calls to `seq-into` from `seq-concatenate` |
|
Date: |
Mon, 24 Aug 2015 15:51:53 +0200 |
|
User-agent: |
Notmuch/0.19 (http://notmuchmail.org) Emacs/25.0.50.2 (x86_64-unknown-linux-gnu) |
Stefan Monnier <address@hidden> writes:
>> Remove the calls to `seq-into` from `seq-concatenate`
>> Since most new types of seq would have to be defined as sequences (cons
>> cells or CL structs, mostly), there is no need to convert the seqs to
>> sequences (which can be a fairly expensive operation).
>
> I don't understand this change. Can't it cause two CL-structs to be
> vconcat'd together, which wouldn't make much sense?
The previous version of `seq-concatenate' did not prevent that, since
CL-structs are vectors, thus sequences, and the function was using
`sequencep' to determine if the seq had to be converted or not.
Nico
--
Nicolas Petton
http://nicolas-petton.fr
signature.asc
Description: PGP signature