[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] master c13a4df: Remove the calls to `seq-into` from `s
Re: [Emacs-diffs] master c13a4df: Remove the calls to `seq-into` from `seq-concatenate`
Tue, 25 Aug 2015 10:32:46 +0200
Notmuch/0.19 (http://notmuchmail.org) Emacs/22.214.171.124 (x86_64-unknown-linux-gnu)
Stefan Monnier <address@hidden> writes:
>>> I don't understand this change. Can't it cause two CL-structs to be
>>> vconcat'd together, which wouldn't make much sense?
>> The previous version of `seq-concatenate' did not prevent that, since
>> CL-structs are vectors, thus sequences, and the function was using
>> `sequencep' to determine if the seq had to be converted or not.
> Indeed, but if we intend to work for new "sequence" types defined via
> CL-struct, that's still a problem.
Yes, it is still a problem. One solution would be to test if the seq is
a cl-struct with, in which case we could use `seq-into'. But then that
would only fix the cl-struct case, not any other.
Description: PGP signature