[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Explicit encoding cookie in Elisp files Add prettify-symbols-alist f

From: Eli Zaretskii
Subject: Re: Explicit encoding cookie in Elisp files Add prettify-symbols-alist for js-mode
Date: Mon, 28 Sep 2015 10:27:53 +0300

> Cc: address@hidden, Simen Heggestøyl
>  <address@hidden>, emacs-devel <address@hidden>
> From: Dmitry Gutov <address@hidden>
> Date: Mon, 28 Sep 2015 07:16:22 +0300
> How about this wording?
> but other files need them even if encoded in UTF-8.  However, if an *.el
> file is intended for use with older Emacs versions (e.g. if it's also
> distributed via ELPA), having an explicit encoding specification is
> still a good idea.

Fine with me.  Although it definitely narrows the applicability of
that suggestion, because the issue is not necessarily "using" the
files, but even visiting them with an older version.  And the latter
happens, at least to me, quite a lot, e.g. when I need to look at
those files on a system where only an older Emacs is installed or

It also contradicts what we have been doing with such files until now,
see below.

And again, it's just a suggestion, not a requirement.  We already have
similar language elsewhere in CONTRIBUTE, for example:

  - There is no need to mention files such as NEWS, MAINTAINERS, and
    FOR-RELEASE, or to indicate regeneration of files such as
    'configure', in the ChangeLog entry.  "There is no need" means you
    don't have to, but you can if you want to.^^^^^^^^^^^^^^^^^^^^^^^^

It's okay to not behave according to such suggestions: that's why they
are worded as non-mandatory suggestions.  Why such strong opposition?

> > Let's agree to disagree about that, okay?
> I don't mind having a difference in opinion, if you don't object to 
> reverting db828f6.

Sigh.  Revert it if you must.  But see below for why I think that's a
desire I don't understand, unless you have some problem with my
commits specifically.

> Having Elisp files default to UTF-8 is a good feature, and you're
> proposing to effectively ignore it.

Did you see how many of our Lisp files already have the cookie that
states UTF-8 encoding?  (Answer: 197.)  Moreover, various features
that generate *.el files automatically insert the cookie there, see
autoload.el and ido.el for just 2 examples.  Did this bother you, or
anyone else, until now?  So why did that single commit, which added a
cookie to 3 more files, for a 1.5% growth, suddenly bother you?  I
just did what we have been doing for many years, something that was
burned into my muscle memory during all those years.

IOW, don't you see how this minuscule issue is blown out of
proportions for reasons I cannot even begin to understand?  And why do
you single out only those 3 files, but say nothing about the others?
If you really dislike those cookies so much, I'd expect you to first
realize the magnitude of the "problem", and then attack it
consistently across the board, rather than pouncing on my single

> > The form and the intense of the objections are out of proportions,
> > for such an insignificant issue/disagreement.
> Sorry about the strong wording. Apparently, that's how I react to a 
> perceived feature/workflow regression made on purpose (not sure how to 
> phrase this better).

My strong perception is that this is how you react to any of my
suggestions or ideas or actions, and this incident is a very good

reply via email to

[Prev in Thread] Current Thread [Next in Thread]