[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Location of tests (again) (was Re: Makefile-help)

From: Eli Zaretskii
Subject: Re: Location of tests (again) (was Re: Makefile-help)
Date: Sat, 07 Nov 2015 13:45:52 +0200

> From: address@hidden (Phillip Lord)
> Date: Sat, 07 Nov 2015 11:22:04 +0000
> Cc: Stephen Leake <address@hidden>,
>       Emacs developers <address@hidden>
> Juanma Barranquero <address@hidden> writes:
> > On Sat, Nov 7, 2015 at 11:55 AM, Phillip Lord <address@hidden>
> > wrote:
> >
> >> Some one suggested to
> >> but tests of C core ~test/automated/src~ which sounded good. But
> >> thinking about it, it probably makes more sense to leave this for C
> >> level testing framework. So now we have
> >>
> >> test/automated/lisp
> >> test/automated/lisp/emacs-lisp
> >> test/automated/lisp/progmodes (and so on....)
> >> test/automated/lisp/c (lisp tests for the C core)
> >
> > This breaks the symmetry between our source layout and the test layout.
> It does, and I think this is unfortunate.

Sorry, I don't understand why not use the simpler

 test/automated/src (tests for the C core)

> > In fact, it seems to me like a nice property that if we have both C and
> > elisp tests for, say, keymap.c, then keymap-tests.c and keymap-tests.el are
> > in close proximity.
> I thought about that. Obviously it makes the Makefile harder (since you
> need one that can cope with both the C framework and the Lisp
> framework), which is why I though to keep things separate. This seemed
> worth breaking the symmetry.

We don't have any C framework, and I very much doubt we will any time
soon.  (I don't even think it's feasible, since Emacs is not a
library, and doesn't provide a way of exercising it from a C program.)
We can move files again if and when we do, just like we intend to move
files now.  OTOH, breaking the symmetry on behalf of a feature we
don't have doesn't sound right to me.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]