[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH PING] Honor 'SOURCE_DATE_EPOCH' when generating autoloads.

From: Paul Eggert
Subject: Re: [PATCH PING] Honor 'SOURCE_DATE_EPOCH' when generating autoloads.
Date: Wed, 23 Dec 2015 13:09:21 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0

Philipp Stephani wrote:
I thought that too, but on second thought it seems rather difficult: the
variable should be set to nil by default in an initialized Emacs (and
probably also in temacs), yet we need a way to set it to t based on the
configuration option.

Doesn't your proposed patch already set deterministic-dump to t based on the configuration option? I don't see the difficulty.

+  (if deterministic-dump "unknown" (system-name))

How about changing this to:

    (when (not deterministic-dump) (system-name))

and document that the value is nil when unavailable? That should be cleaner than the confusion if a system name actually happens to be "unknown". Similarly, init_system_name should leave Vsystem_name alone when DETERMINISTIC_DUMP.


Please change this to "if (DETERMINISTIC_DUMP)", and similarly for other uses, and arrange for DETERMINISTIC_DUMP to be a constant false or true. Nowadays we should prefer macros to constants only when they're really necessary, which isn't the case here.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]