[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Errors in redisplay in eww

From: Lars Magne Ingebrigtsen
Subject: Re: Errors in redisplay in eww
Date: Sat, 09 Jan 2016 10:13:16 +0100
User-agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux)

Eli Zaretskii <address@hidden> writes:

> No, add-face-text-property and shr-colorize-region are not the
> culprit, at least they don't seem to be.  The problem is here:
>             (dolist (line lines)
>               (end-of-line)
>               (let ((start (point)))
>                 (insert
>                  line
>                  (propertize " "
>                              'display `(space :align-to (,pixel-align))
>                              'face (and (> (length line) 0)
>                                         (shr-face-background
>                                          (get-text-property
>                                           (1- (length line)) 'face line)))
>                              'shr-table-indent shr-table-id)
>                  shr-table-vertical-line)
>                 (shr-colorize-region
>                  start (1- (point)) (nth 5 column) (nth 6 column)))
>               (forward-line 1))
> shr-face-background returns nil when get-text-property returns just
> variable-pitch, so we get 'face nil' in the properties, and the rest
> is history.

I see.

> Can you tell how come get-text-property returns something else in your
> case?

No, it has to return the same as you're seeing.  Is it possible that
my Emacs just isn't warning about these nil faces?

The right fix here is probably not to propertize the `face' is
`shr-face-background' returns nil, I guess.

(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

reply via email to

[Prev in Thread] Current Thread [Next in Thread]