[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Is it time to drop ChangeLogs?

From: Nikolaus Rath
Subject: Re: Is it time to drop ChangeLogs?
Date: Mon, 07 Mar 2016 21:33:50 -0800
User-agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/24.4 (gnu/linux)

On Mar 07 2016, Stefan Monnier <address@hidden> wrote:
>> When I submitted my first Emacs patch, I was astonished when I was asked
>> to re-submit with my commit message essentially duplicated in the
>> ChangeLog.
> I can't remember ever asking this kind of duplication.  We used to
> duplicate the ChangeLog-info in the ChangeLog file and in the commit
> message (tho we stopped doing it a year ago), but we never asked for it
> to be duplicated in the email messages that submits a patch.
> So I have the impression that I'm misunderstanding you.  Could you
> describe more precisely the kind of duplication you're talking about?

No, you understood me correctly. However, I've just looked this up again
and it turns out I was actually submitting a patch to Gnus, not
Emacs. It was eventually committed by Eric Abrahamsen to the Gnus git
repo, who first asked me to re-submit my patch with a commit message
that was formatted like a Changelog entry, and to duplicate the message
in the ChangeLog itself. It seemed to me that he considered that a
questionable practice himself, but said it was obligatory because Gnus
closely followed the Emacs standards here.

Unfortunately that discussion never made it into the bug
(http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20956), so I'm
paraphrasing from memory. But I'm pretty sure I'm remembering correctly,
because I was so surprised by this.


GPG encrypted emails preferred. Key id: 0xD113FCAC3C4E599F
Fingerprint: ED31 791B 2C5C 1613 AF38 8B8A D113 FCAC 3C4E 599F

             »Time flies like an arrow, fruit flies like a Banana.«

reply via email to

[Prev in Thread] Current Thread [Next in Thread]