[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] emacs-25 e30c3e9: Fix EOL decoding in vc-annotate with
Re: [Emacs-diffs] emacs-25 e30c3e9: Fix EOL decoding in vc-annotate with SVN back-end on MS-Windows
Fri, 01 Apr 2016 09:21:25 -0400
Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux)
>> > + ;; On DOS/Windows, "svn annotate" will produce CRLF EOLs even
>> > + ;; if the original file has Unix EOLs, which will show ^M
>> > + ;; characters in the Annotate buffer. Prevent that by forcing
>> > + ;; DOS EOL decoding.
>> > + (if (memq system-type '(windows-nt ms-dos))
>> > + (setq coding-system-for-read
>> > + (coding-system-change-eol-conversion
>> > coding-system-for-read
>> > + 'dos)))
>> Why do we need to put this in vc-annotate rather than in vc-svn.el?
> Any command running on MS-Windows should be expected to produce a CRLF
> output, so inheriting EOL decoding from the buffer is not a good idea.
So you're saying that it's not just "svn annotate" that does that but
(e.g.) "git annotate" does it as well? If so, please clarify the
comment to explain that "svn annotate" is just one example.