[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 0695108 2/2: Revert "Add `r'/`l' grep command history command
Re: master 0695108 2/2: Revert "Add `r'/`l' grep command history commands"
Mon, 04 Apr 2016 18:15:43 +0300
> From: John Wiegley <address@hidden>
> Date: Sun, 03 Apr 2016 22:18:59 -0700
> Cc: address@hidden
> >>>>> Lars Magne Ingebrigtsen <address@hidden> writes:
> > An contrary to popular belief, reverting code is not a great way to motivate
> > people to contribute.
> I agree, I just wanted to stop any further work before we started having merge
> commits and other changes sitting on top of those.
Can we continue discussing the design from the point we stopped,
One comment that I have about the feature as it was committed is that
if we want to have an easy way of rerunning past commands, then it
should be defined in compilation-mode, so that all its derivatives
will get it.
I also don't see a lot of mnemonic value in binding these commands to
'l' and 'r', and would suggest additional bindings which would be
easier to remember even for those who don't browse URLs all day long.
I also think that 100-long history for these commands is waaaaay too
much. It should be a defcustom, and the default value should be maybe
10 or 16.
Re: master 0695108 2/2: Revert "Add `r'/`l' grep command history commands", Lars Magne Ingebrigtsen, 2016/04/04