[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Considered Harmful 73d213: "Comint, term, and compile new set Emacs"

From: Phillip Lord
Subject: Re: Considered Harmful 73d213: "Comint, term, and compile new set Emacs"
Date: Wed, 06 Apr 2016 18:53:30 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Paul Eggert <address@hidden> writes:

> On 04/05/2016 03:08 PM, Phillip Lord wrote:
>> The main problem is that use of cask tends to weave in and out of
>> different Emacs and also Makefiles. So, I use this:
>> EMACS ?= emacs
>> CASK ?= cask
>> -include makefile-local
>> all: install test
>> install:
>>      EMACS=$(EMACS) cask install
>> Which (did) work fine on Emacs-25
> But that doesn't work on Emacs 24, right?

It doesn't have to work on Emacs-24. I don't use Emacs-24 to develop in,
only Emacs-25, at least partly because Emacs-25 doesn't (didn't) set

> And if you do something like the
> following:
>     EMACS ?= emacs
>     CASK ?= cask
>     ifeq ($(EMACS),t)
>       EMACS = emacs
>     endif
>     install:
>         EMACS=$(EMACS) cask install
> This should work with both Emacs 24 and emacs-25 current.

At this juncture, I think the sensible thing is to give up on using
EMACS as both an environment variable and a makefile variable. Putting
hacks into my make file to distinguish between running inside and
outside of Emacs is not a solution. The same make file should work.

To repeat, my belief is that a behaviour that was installed
deliberately, and which has been on master/emacs-25 for a year should
not have been removed in pre-test. I think Stefan's patch needs
restoring. Are you prepared to do this?

Failing that, I will back out my changes to cask.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]