[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] master 65797b1: Make icomplete respect `completion-ign

From: Lars Ingebrigtsen
Subject: Re: [Emacs-diffs] master 65797b1: Make icomplete respect `completion-ignored-extensions'
Date: Thu, 28 Apr 2016 23:37:42 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux)

Stefan Monnier <address@hidden> writes:

>> --- a/lisp/icomplete.el
>> +++ b/lisp/icomplete.el
>> @@ -388,6 +388,9 @@ matches exist."
>>      (progn ;;(debug (format "Candidates=%S field=%S" candidates name))
>>             (format " %sNo matches%s" open-bracket close-bracket))
>>        (if last (setcdr last nil))
>> +      (when (and minibuffer-completing-file-name
>> +                 icomplete-with-completion-tables)
>> +        (setq comps (completion-pcm--filename-try-filter comps)))
>>        (let* ((most-try
>>                (if (and base-size (> base-size 0))
>>                    (completion-try-completion
> Yuck.  We should really extend completion-tables yet a bit more
> (probably via the completion-metadata or completion-extra-properties) so
> we don't need to check minibuffer-completing-file-name and we can use
> similar features in other completions.

Should I revert the patch?

(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

reply via email to

[Prev in Thread] Current Thread [Next in Thread]