[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] master 65797b1: Make icomplete respect `completion-ign
Re: [Emacs-diffs] master 65797b1: Make icomplete respect `completion-ignored-extensions'
Sat, 30 Apr 2016 09:33:32 -0400
Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux)
>> Yuck. We should really extend completion-tables yet a bit more
>> (probably via the completion-metadata or completion-extra-properties) so
>> we don't need to check minibuffer-completing-file-name and we can use
>> similar features in other completions.
> Should I revert the patch?
No, that "yucky stuff" is already present at other places in
minibuffer.el. Your patch didn't make it significantly worse.
It should makes it yet a bit more obvious that a better solution is
I didn't add a solution to this problem originally because it seemed to
be a lot of trouble, but in the mean time I added the
completion-metadata and completion-extra-properties stuff, so I think it
should be reasonably easy now to use those to implement that