[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Recent commit modifying mark-whole-buffer (master/aeb613ea95b7970e66

From: Lars Ingebrigtsen
Subject: Re: Recent commit modifying mark-whole-buffer (master/aeb613ea95b7970e66d663ec5cba54e9ec0528fa)
Date: Sat, 30 Apr 2016 16:34:15 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux)

Stefan Monnier <address@hidden> writes:

>> Yup.  Like I said in the bug report, I think the solution here is to
>> have read-from-minibuffer not apply the default face if there are any
>> faces specified on the prompt string.
> "Not apply" sounds wrong.  Better do an "append" so the face properties
> provided to read-from-minibuffer get merged with the
> minibuffer-prompt face.

That was my original idea, but I think Drew is right that if somebody
has said

(read-from-minibuffer (propertize "foo" 'face 'bold))

it's pretty unlikely that they want `bold' merged with the blue face...

I mean, they can also bind `minibuffer-prompt-properties', but
that's...  not very convenient, since it has other, necessary
properties, or redefine the minibuffer-prompt face, but that's also not
what you want to do for a single prompt.

(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

reply via email to

[Prev in Thread] Current Thread [Next in Thread]