[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Emacs bug #23794; sort-line behavior regressed from prior Emacs vers

From: Eli Zaretskii
Subject: Re: Emacs bug #23794; sort-line behavior regressed from prior Emacs versions
Date: Sun, 19 Jun 2016 19:55:14 +0300

> From: Robert Weiner <address@hidden>
> Date: Sun, 19 Jun 2016 12:51:08 -0400
> Cc: Drew Adams <address@hidden>, Richard Stallman <address@hidden>, 
>       emacs-devel <address@hidden>, address@hidden
> On Sun, Jun 19, 2016 at 12:30 PM, Eli Zaretskii <address@hidden> wrote:
>  Didn't think that far, but is it really clean for sort-lines to have
>  special code for some major mode? I thought a better way is to
>  override the default behavior by having sort-lines call functions
>  through funcall or somesuch, and then outline modes could set the
>  appropriate variable to the function of their liking?
> The problem with that approach is that each mode has to be aware of this and 
> add a setting, really not much
> different than each mode having its own sort function or way of calling a 
> sort function. It is much more useful
> to centralize the behavior within the sorting library, even if it adds some 
> conditional complexity to the code.

Not necessarily: if you set that up in outline-mode, all of its
descendants will inherit the setting for free.

> Here is the suggested patch to do it this way. -- Bob

Thanks, I hope others will comment on this.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]