[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Compilation warnings in mouse.el

From: Dmitry Gutov
Subject: Re: Compilation warnings in mouse.el
Date: Wed, 13 Jul 2016 01:56:30 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:47.0) Gecko/20100101 Thunderbird/47.0

On 07/12/2016 08:04 AM, Eli Zaretskii wrote:

Unlike Stefan, I think we should add :group to every defcustom.

The additions to each file just have to be consistent with what's already there. The presently discussed patch, wasn't.

Speaking of personal preference, however, I'd rather using the `mouse' group didn't work, in the absence of a defgroup somewhere.

Having them mysteriously missing from some of them is a time bomb:
remove or add enough defcustoms in the same file, and you have a bug.

How would removing a defcustom, or merely adding one, lead to a bug?

The new defcustom might have :group unspecified, and if there's no defgroup in the current file, it would become a problem, but that's unrelated to any defcustom's already present in the file.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]