[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Compilation warnings in mouse.el

From: Eli Zaretskii
Subject: Re: Compilation warnings in mouse.el
Date: Wed, 13 Jul 2016 17:31:34 +0300

> From: Stefan Monnier <address@hidden>
> Date: Tue, 12 Jul 2016 18:58:12 -0400
> EZ> Unlike Stefan, I think we should add :group to every defcustom. Having
> EZ> them mysteriously missing from some of them is a time bomb: 
> The way I see it, defcustoms should pretty much never have :group, and
> the group to which they belong is simply determined by the file in which
> they occur.

But as long as such a system isn't installed, we shouldn't behave as
if it were.  (And what you propose is not without downsides, I think.)

> EZ> remove or add
> EZ> enough defcustoms in the same file, and you have a bug.
> I don't see how removing/adding defcustoms in the same file
> would introduce problems.

We just saw such a problem, no?

> PS: Incidentally, we have two definitions of the `mouse' group
> in cus-edit.el:

Thanks.  Bonus points for fixing that.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]