[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] master 5811404: Replace eldoc-documentation-function w
From: |
Leo Liu |
Subject: |
Re: [Emacs-diffs] master 5811404: Replace eldoc-documentation-function with a hook |
Date: |
Thu, 14 Jul 2016 21:36:23 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.0.95 (OS X 10.11.5) |
On 2016-07-09 20:27 -0400, Stefan Monnier wrote:
> A *-function variable is not an advice, but a hook.
>
> It's a different kind of hook than those manipulated by add-hook (which
> have names ending in -hook or -functions), but it's still a hook and
> those have been used for many years in various parts of Emacs.
>
> It just so happens that the operations that can manipulate those hooks
> conveniently (add-function/remove-function) are provided in the same
> file as the new advice-add, but that's only because it was convenient
> and natural to implement advice-add on top of those new operations.
May we have this incompatible change reverted?
Thanks,
Leo