[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] master 5811404: Replace eldoc-documentation-function w
Re: [Emacs-diffs] master 5811404: Replace eldoc-documentation-function with a hook
Thu, 7 Jul 2016 19:59:54 -0400
Mutt/1.6.1+68 (bf1c73de2b7c) (2016-04-27)
On 07/07/16 at 12:31pm, John Wiegley wrote:
> >>>>> Stefan Monnier <address@hidden> writes:
> > I thought it was agreed that it would be a bad idea.
> I was asked in IRC about this patch, and I couldn't see anything objectionable
> about it. However, clearly I was unaware of previous discussion on the matter.
> Mark, could you please revert until we have more consensus that we want to do
> this? Thank you.
Commit fd020a29 was implemented only to make it possible for the default
value to be used, something hooks already do. See Bug#19338.
It is unclear what discussion you are talking about. Perhaps it's
here, but if not, I hope you will read it before asking me to make
more commit noise. One could refer to a number of sources for developer
opinion on using advice in core, but perhaps it is best to quote the
[…] advice should be reserved for the cases where you cannot modify
a function’s behavior in any other way. If it is possible to do
the same thing via a hook, that is preferable (see Hooks). […] In
particular, Emacs’s own source files should not put advice on
functions in Emacs. (There are currently a few exceptions to this
convention, but we aim to correct them.)