[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix RefTeX to show table of contents for dtx files

From: Sašo Živanović
Subject: Re: [PATCH] Fix RefTeX to show table of contents for dtx files
Date: Mon, 2 Jan 2017 16:41:24 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1

Hi Tassilo!

Thanks for the prompt reply and commit!

On 02. 01. 2017 13:22, Tassilo Horn wrote:
Sašo Živanović <address@hidden> writes:

Hi Sašo,

I've fixed a tiny bug in RefTeX: TOC was not shown for dtx files.

Good catch, thanks!

I've committed your patch with a slight modification.  Instead of this

-                 (when toc-entry
+                 (when (and toc-entry
+                            (equal
+                             (equal (char-after bound) ?%)
+                             (string-suffix-p ".dtx" file)
+                             ))

I used

                   (when (and toc-entry
                            (eq ;; Either both are t or both are nil.
                             (= (char-after bound) ?%)
                             (string-suffix-p ".dtx" file)))

which looks a bit more clear to me.
Fine with me. You see that my lisp is pretty rudimentary ...

I've seen that this is your first patch to Emacs, and given that it's
less than 15 lines of code, I can commit it for you as-is.  However, if
you plan to contribute more in the future, a copyright assignment will
be due.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]