[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: bug#27644: 26.0.50; [PATCH] Add binding for vc-region-history

From: Kaushal Modi
Subject: Re: bug#27644: 26.0.50; [PATCH] Add binding for vc-region-history
Date: Thu, 28 Sep 2017 17:22:04 +0000

On Thu, Sep 28, 2017 at 12:59 PM John Wiegley <address@hidden> wrote:
Isn't C-x v h already `vc-insert-headers'?

Hi John, 

As mentioned earlier in the thread, Stefan suggested this binding as he never found the default binding useful[1], Dmitry corroborated that[2], I have never found the default useful. Later Clement and Jostein also chimed in a +1[3, 4].

So far there has been no opposition to binding C-x v h with vc-region-history. 

I am basically proposing to bind the super-useful vc-region-history to "something" in "C-x v" map. I offered C-x v H. But based on the above discussion C-x v h makes more sense.

I would be great to get a clear "yes" or "no" as this issue seems to have lingered too long.

I'd put this very concisely as:

(let ((res (binding--vc-region-history--resolution)))
  (cond ((string= "yes, C-x v h" res)
         "best option")
        ((string= "yes, C-x v H" res)
         "good option")
        ((string= "no, don't bind vc-region-history" res)
         "bad option, but I'll accept")
         (error "invalid"))))

[1]: http://lists.gnu.org/archive/html/emacs-devel/2017-09/msg00772.html 
[2]: http://lists.gnu.org/archive/html/emacs-devel/2017-09/msg00786.html
[3]: http://lists.gnu.org/archive/html/emacs-devel/2017-09/msg00823.html
[4]: http://lists.gnu.org/archive/html/emacs-devel/2017-09/msg00950.html

Kaushal Modi

reply via email to

[Prev in Thread] Current Thread [Next in Thread]