[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: bug#27644: 26.0.50; [PATCH] Add binding for vc-region-history

From: John Wiegley
Subject: Re: bug#27644: 26.0.50; [PATCH] Add binding for vc-region-history
Date: Thu, 28 Sep 2017 10:24:30 -0700
User-agent: Gnus/5.130016 (Ma Gnus v0.16) Emacs/26.0 (darwin)

>>>>> Kaushal Modi <address@hidden> writes:

> So far there has been no opposition to binding C-x v h with
> vc-region-history.

> I am basically proposing to bind the super-useful vc-region-history to
> "something" in "C-x v" map. I offered C-x v H. But based on the above
> discussion C-x v h makes more sense.

> I would be great to get a clear "yes" or "no" as this issue seems to have
> lingered too long.

> I'd put this very concisely as:

> (let ((res (binding--vc-region-history--resolution)))
>   (cond ((string= "yes, C-x v h" res)
>          "best option")
>         ((string= "yes, C-x v H" res)
>          "good option")
>         ((string= "no, don't bind vc-region-history" res)
>          "bad option, but I'll accept")
>         (t
>          (error "invalid"))))

Hah, I love it. :)

I'm all for making it C-x v h, and having C-x v H insert headers. The former
is by far the more common operation, and in this case I'm willing to break
with tradition for better convenience. Please give this a good notice in the
NEWS file, so people notice.

John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

reply via email to

[Prev in Thread] Current Thread [Next in Thread]