[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] master d48e07a: * lisp/simple.el (next-error-find-buff

From: Stefan Monnier
Subject: Re: [Emacs-diffs] master d48e07a: * lisp/simple.el (next-error-find-buffer-function): New defcustom.
Date: Sun, 25 Feb 2018 22:24:38 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

>>> +(defcustom next-error-find-buffer-function nil
>> Why make it a defcustom rather than a defvar?
> I think we'll want to provide a set of predefined functions in the future,
> for the user to choose one from.

So a defcustom makes sense, good.

>>> +   (when next-error-find-buffer-function
>>> +     (funcall next-error-find-buffer-function avoid-current
>>> +                                              extra-test-inclusive
>>> +                                              extra-test-exclusive))
>> Could you arrange for the default value of this new *-function var not
>> to be nil so we can modify it with add-function?
> Personally, I don't really expect this variable to be modified
> programmatically. And if it is, most likely not in a "function
> combination" fashion.

But using `ignore` instead of `nil` both simplifies the code and makes
the var compatible with add-function, so it doesn't matter if
`add-function` is really useful with it.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]