[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] master d48e07a: * lisp/simple.el (next-error-find-buff
Re: [Emacs-diffs] master d48e07a: * lisp/simple.el (next-error-find-buffer-function): New defcustom.
Tue, 27 Feb 2018 23:39:13 +0200
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu)
>>>> +(defcustom next-error-find-buffer-function nil
>>> Why make it a defcustom rather than a defvar?
>> I think we'll want to provide a set of predefined functions in the future,
>> for the user to choose one from.
> So a defcustom makes sense, good.
>>>> + (when next-error-find-buffer-function
>>>> + (funcall next-error-find-buffer-function avoid-current
>>>> + extra-test-inclusive
>>>> + extra-test-exclusive))
>>> Could you arrange for the default value of this new *-function var not
>>> to be nil so we can modify it with add-function?
>> Personally, I don't really expect this variable to be modified
>> programmatically. And if it is, most likely not in a "function
>> combination" fashion.
> But using `ignore` instead of `nil` both simplifies the code and makes
> the var compatible with add-function, so it doesn't matter if
> `add-function` is really useful with it.
So I just changed the default value from nil to ‘ignore’.