[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Tramp and fixnum

From: Michael Albinus
Subject: Re: Tramp and fixnum
Date: Sun, 26 Aug 2018 18:44:57 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

Eli Zaretskii <address@hidden> writes:

>> Yes, sorry, I meant 'file-attributes'. The fishy-looking code is in 
>> tramp-convert-file-attributes. Here's one snippet:
>>      (when (and (floatp (nth 2 attr))
>>                 (<= (nth 2 attr) most-positive-fixnum))
>>        (setcar (nthcdr 2 attr) (round (nth 2 attr))))
>> Although this snippet shouldn't hurt, it should be unnecessary once 
>> file-attributes is fixed to not return floats.
> Fixed in what version of Emacs?  Tramp wants to support more than just
> the latest master version.

Yes, back to Emacs 24.

>> The main offender is the inode converter in that function, which
>> splits integers
>> into three parts, whereas it should simply keep the integers as-is since 
>> they 
>> don't overflow any more.
> They do in older Emacs versions, AFAIR.

Yes. See Bug#25854, which triggered this code. It was reported towards
Emacs 26.0.50.

Best regards, Michael.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]