[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Tramp and fixnum

From: Paul Eggert
Subject: Re: Tramp and fixnum
Date: Tue, 28 Aug 2018 08:18:39 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

Michael Albinus wrote:

And for the inode number conversion, I check whether function `bignump'
is available. If yes, I don't convert.

I must be slow this morning, but I don't see why that test needs to know whether bignums are supported. That is, for this change:

-    ;; Convert inode.
-    (unless (listp (nth 10 attr))
+    ;; Convert inode.  Big numbers have been added to Emacs 27.
+    (unless (or (fboundp 'bignump) (listp (nth 10 attr)))

How about changing to the following instead?

     (let ((inode (nth 10 attr)))
        (unless (or (integerp inode) (listp inode))

That is, if the inode number is already an integer, leave it alone. This should work regardless of whether bignums are supported.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]