[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] open bookmark in other frame

From: Pierre-Yves Luyten
Subject: Re: [PATCH] open bookmark in other frame
Date: Thu, 11 Oct 2018 13:30:23 +0200
User-agent: Roundcube Webmail/1.3.7

Le 2018-10-11 09:19, Karl Fogel a écrit :
Drew Adams <address@hidden> writes:
My suggestions in this regard, FWIW:

1. Don't use `view-buffer-other-frame'.

Agreed -- there's no reason it should be read-only.  Jumping to a
bookmark doesn't normally cause the destination to be read-only, so
there's no reason that should happen just because we're in a new

noted i will review this

2. Don't use `F' as the key binding in the bookmark-list buffer.
   `F' is more often used for files than for frames. Maybe use `5'.


I don't have a strong opinion here, but my fingers also lean slightly
toward "5" because of `C-x 5 b', for what it's worth.

now you suggest 5 it looks like a nice way to go.

I will review patch in the upcoming days to solve these two points and improve commit message


reply via email to

[Prev in Thread] Current Thread [Next in Thread]