[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] master 9dd95bf: * lisp/emacs-lisp/pcase.el (pcase--u1)

From: Eli Zaretskii
Subject: Re: [Emacs-diffs] master 9dd95bf: * lisp/emacs-lisp/pcase.el (pcase--u1): Fix bignums
Date: Fri, 26 Oct 2018 18:02:39 +0300

> From: Stefan Monnier <address@hidden>
> Cc: address@hidden
> Date: Fri, 26 Oct 2018 10:17:33 -0400
> > Stefan, this change needs a suitable change in the docs (both the doc
> > string and the ELisp manual): they still claim integers are compared
> > using 'equal', which AFAIU is now inaccurate.
> AFAIK using `eql` gives the same result as comparing with `equal`:
> It's just an internal optimization that is transparent to the user.

That's so, but I find documentation that explicitly calls out 'equal'
misleading when the code actually invokes 'eql' instead.  Maybe we
should make the text less explicit then?

> So, just like we did not document the fact that integers (and symbols)
> where actually compared with `eq`

That we already had misleading docs doesn't mean we need to continue
having misleading docs.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]