[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] master 9dd95bf: * lisp/emacs-lisp/pcase.el (pcase--u1)
From: |
Stefan Monnier |
Subject: |
Re: [Emacs-diffs] master 9dd95bf: * lisp/emacs-lisp/pcase.el (pcase--u1): Fix bignums |
Date: |
Fri, 26 Oct 2018 10:17:33 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
> Stefan, this change needs a suitable change in the docs (both the doc
> string and the ELisp manual): they still claim integers are compared
> using 'equal', which AFAIU is now inaccurate.
AFAIK using `eql` gives the same result as comparing with `equal`:
It's just an internal optimization that is transparent to the user.
So, just like we did not document the fact that integers (and symbols)
where actually compared with `eq`, there's no need to document that they
are now compared with `eql`: the intended semantics is to give the same
result as when comparing with `equal` so that's what we document.
The patch simply fixes the (unlikely but possible now) case where the
pattern is an integer that's not a fixnum.
Stefan
- [Emacs-diffs] master 9dd95bf: * lisp/emacs-lisp/pcase.el (pcase--u1): Fix bignums, Eli Zaretskii, 2018/10/26
- Re: [Emacs-diffs] master 9dd95bf: * lisp/emacs-lisp/pcase.el (pcase--u1): Fix bignums,
Stefan Monnier <=
- Re: [Emacs-diffs] master 9dd95bf: * lisp/emacs-lisp/pcase.el (pcase--u1): Fix bignums, Eli Zaretskii, 2018/10/26
- Re: [Emacs-diffs] master 9dd95bf: * lisp/emacs-lisp/pcase.el (pcase--u1): Fix bignums, Stefan Monnier, 2018/10/26
- Re: [Emacs-diffs] master 9dd95bf: * lisp/emacs-lisp/pcase.el (pcase--u1): Fix bignums, Eli Zaretskii, 2018/10/26
- Re: [Emacs-diffs] master 9dd95bf: * lisp/emacs-lisp/pcase.el (pcase--u1): Fix bignums, Stefan Monnier, 2018/10/26
- Re: [Emacs-diffs] master 9dd95bf: * lisp/emacs-lisp/pcase.el (pcase--u1): Fix bignums, Paul Eggert, 2018/10/26
- Re: [Emacs-diffs] master 9dd95bf: * lisp/emacs-lisp/pcase.el (pcase--u1): Fix bignums, Stefan Monnier, 2018/10/26
- Re: [Emacs-diffs] master 9dd95bf: * lisp/emacs-lisp/pcase.el (pcase--u1): Fix bignums, Eli Zaretskii, 2018/10/26
- Re: [Emacs-diffs] master 9dd95bf: * lisp/emacs-lisp/pcase.el (pcase--u1): Fix bignums, Stefan Monnier, 2018/10/26
- Re: [Emacs-diffs] master 9dd95bf: * lisp/emacs-lisp/pcase.el (pcase--u1): Fix bignums, Andy Moreton, 2018/10/27