[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fill column indicator functionality

From: Robert Pluim
Subject: Re: Fill column indicator functionality
Date: Tue, 02 Apr 2019 19:01:45 +0200

>>>>> On Tue, 2 Apr 2019 18:36:23 +0200, Ergus <address@hidden> said:

    Ergus> I just pushed a new branch with the fill-column-indicator
    Ergus> feature.  I would prefer to rebase before pushing to the
    Ergus> master branch. (In my ideal world I will rebase and then do
    Ergus> a merge with -no-ff. But this is not the workflow you have
    Ergus> here)

I took a quick look. Itʼs three commits, including the NEWS
changes. Any reason you donʼt want to squash those into a single

    Ergus> So, how is decided when to move this to the master branch?
    Ergus> (the equivalent to accept the pull request)

    Ergus> There are changes in the NEWS already but not in the
    Ergus> manual. So, just tell me the following steps.

The NEWS changes have some minor issues (spelling, two spaces after
full stop, spurious whitespace), but the new user variables and modes
need descriptions in the user manual.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]