[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: improve "next locus from <buffer>" messages

From: Stephen Leake
Subject: Re: improve "next locus from <buffer>" messages
Date: Thu, 04 Apr 2019 05:41:30 -0800
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (windows-nt)

Felician Nemeth <address@hidden> writes:

>>>>> The attached patch changes it so the message is only output when the
>>>>> locus changes.
>>>>> Comments?
> I'm not completely sure, but the proposed patch seems to assume that
> next-error is only called from compilation-start.  

No, that assumption is not made. I added the message in
compilation-start because otherwise it does not print a message when the
locus is changed.

I did not search the rest of emacs for places that set
next-error-last-buffer, so there may be other places that need a

Yes; xref--xref-buffer-mode sets next-error-last-buffer without a

It makes sense to print a message only when the error locus
change might be unexpected. If the user has started a compilation, they
expect error messages to come from *compilation*; similarly for *xref*.
The original discussion included things like flymake, which is invoked
in the background.

I'll take out the message in compilation-start.

-- Stephe

reply via email to

[Prev in Thread] Current Thread [Next in Thread]