[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] Add module functions to convert from and to big integers

From: Eli Zaretskii
Subject: Re: [PATCH 2/2] Add module functions to convert from and to big integers.
Date: Wed, 24 Apr 2019 20:11:25 +0300

> From: Philipp Stephani <address@hidden>
> Date: Wed, 24 Apr 2019 18:57:40 +0200
> Cc: Paul Eggert <address@hidden>, Emacs developers <address@hidden>, 
>       Philipp Stephani <address@hidden>
> Right now I see 2 options:
> 1. Don't support these functions at all if GMP isn't available (i.e.
> signal an error unconditionally)
> 2. Add another preprocessor macro that would stop emacs-module.h from
> including gmp.h.
> (1) seems a bit easier and cleaner, but means that we wouldn't support
> these functions if Emacs isn't compiled with GMP support.

I don't think I understand (2): how would you declare GMP-related data
types used in emacs-module.c, if you don't include gmp.h?

And there might be option (3): have emacs-module.h duplicate the
portion of mini-gmp.h that are needed when gmp.h isn't available.
It's a bit inelegant, and maintenance burden, but maybe not grave
enough to decide that wer cannot support bignums without a real GMP.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]