[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Unbreak build when building without GMP support.

From: Philipp Stephani
Subject: Re: [PATCH] Unbreak build when building without GMP support.
Date: Wed, 24 Apr 2019 21:19:54 +0200

Am Mi., 24. Apr. 2019 um 21:06 Uhr schrieb Eli Zaretskii <address@hidden>:
> > From: Philipp Stephani <address@hidden>
> > Date: Wed, 24 Apr 2019 20:49:34 +0200
> > Cc: Emacs developers <address@hidden>, Philipp Stephani <address@hidden>
> >
> > > Btw, why are we including emacs-module.h in lisp.h?  IME, this usually
> > > causes trouble, so it is best to avoid that.
> >
> > lisp.h needs types from emacs-module.h to define Lisp_Module_Function.
> A single data type?  I'd rather move XMODULE_FUNCTION to
> emacs-module.c, and the data type definition and all the other related
> stuff to emacs-module.h.  It isn't worth the hassle.

We shouldn't move anything to emacs-module.h because it's a public
header, to be used outside of Emacs.
What hassle are you talking about? There is no hassle. We have been
including emacs-module.h in lisp.h for years, and there was never any

reply via email to

[Prev in Thread] Current Thread [Next in Thread]