[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Remove display member of glyph_string

From: Eli Zaretskii
Subject: Re: [PATCH] Remove display member of glyph_string
Date: Thu, 09 May 2019 08:50:13 +0300

> From: Alex Gramiak <address@hidden>
> Date: Wed, 08 May 2019 21:52:56 -0600

Each FRAME_X_DISPLAY call expands into applying a struct offset 4
times.  Do we care about the (small) additional inefficiency?  AFAIU,
that was the cause for maintaining the result inside the glyph_string
structure in the first place.

> The only other location that FRAME_X_DISPLAY appears in non-X code is in
> the argument to Free_Pixmap in image.c, which can hopefully be
> refactored out in a later patch; at that point the other terms can
> remove their trivial FRAME_X_DISPLAY definitions.

So should we do both in one go, perhaps?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]