[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Remove display member of glyph_string

From: Alex Gramiak
Subject: Re: [PATCH] Remove display member of glyph_string
Date: Thu, 09 May 2019 12:21:07 -0600
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)

Eli Zaretskii <address@hidden> writes:

>> From: Alex Gramiak <address@hidden>
>> Cc: address@hidden
>> Date: Thu, 09 May 2019 11:16:06 -0600
>> > There's one more instance of FRAME_X_DISPLAY in xdisp.c which was
>> > left, and it will fail compilation on non-X platforms.
>> >
>> > Otherwise, this LGTM, thanks.
>> I only see one such instance, and it's surrounded by:
>>  #if false && defined HAVE_X_WINDOWS
>> So it should be good, no?
> That one, yes.  But there's one more, and it isn't conditioned by
> HAVE_X_WINDOWS.  Are you maybe looking on a wrong branch?  I'm on
> master.

You mean the one in init_glyph_string, right? That was removed in my
first patch, which I've attached again below:

Attachment: 0001-Remove-display-member-of-glyph_string.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]