Re: string_char_to_byte and string_byte_to_char micro-optimisation

[Stefan Monnier]

>> ... and uses `aref` on it extensively.
> Right.  And/or 'aset'.

Right, but `aset` is even more rare on multibyte strings.

> Other candidates are 'string-match' and 'replace-match'.

`replace-match` has to copy the string, so charpos<->bytepos conversion
doesn't slow it down significantly (I'd guess it's at most a factor of 2).

`string-match` is only affected by charpos<->bytepos is you use the
`start` argument, and the time to perform the actual regexp search will
usually dwarf the charpos<->bytepos conversion, so I think it can only
be noticeably slowed down by charpos<->bytepos conversion in
"pathological" cases where we `start` in the middle of a longish string
and we immediately find a short match.

In contrast, `aref` never does much more than the charpos<->bytepos
conversion itself.


        Stefan