[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] master 50c5d56: --with-cairo is no longer experimental

From: Eli Zaretskii
Subject: Re: [Emacs-diffs] master 50c5d56: --with-cairo is no longer experimental
Date: Sat, 09 Nov 2019 08:44:56 +0200

> From: Robert Pluim <address@hidden>
> Cc: address@hidden
> Date: Fri, 08 Nov 2019 22:40:52 +0100
> The following works for me:

LGTM, thanks.  I would just change the name of the new function to
something like font_is_ignored, which is slightly more general, and so
will still fit if we later modify that function to do something
instead of in addition to matching against face-ignored-fonts.  But
that's admittedly splitting hair.

Another thing that I miss in the patch is the actual setting of
face-ignored-fonts for GTK builds.  We want to do that by default,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]