[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 3fdc36e: Error out on --with-harfbuzz without HarfBuzz suppor
From: |
Andreas Schwab |
Subject: |
Re: master 3fdc36e: Error out on --with-harfbuzz without HarfBuzz support |
Date: |
Mon, 18 Nov 2019 00:42:30 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
On Nov 17 2019, Lars Ingebrigtsen wrote:
> diff --git a/configure.ac b/configure.ac
> index 3b6a2a6..0976b66 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -3469,6 +3469,11 @@ if test "${HAVE_X11}" = "yes" && test
> "${HAVE_FREETYPE}" = "yes" \
> fi
> fi
>
> +# The user explicitly asked for HarfBuzz, but it won't be used.
> +if test "${with_harfbuzz}" == "yes" && test "$HAVE_HARFBUZZ" != "yes"; then
> + AC_MSG_ERROR([HarfBuzz wanted, but won't be used. Maybe some library
> files are missing?]);
> +fi
That gives a spurious error when configuring with --without-x.
Also, test a == b is a bashism. The string compare operator is =.
Andreas.
--
Andreas Schwab, address@hidden
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
- Re: master 3fdc36e: Error out on --with-harfbuzz without HarfBuzz support,
Andreas Schwab <=