[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix fit-frame-to-buffer for multi-monitor setup.

From: martin rudalics
Subject: Re: [PATCH] Fix fit-frame-to-buffer for multi-monitor setup.
Date: Sat, 29 Feb 2020 17:05:28 +0100

> I've noticed `fit-frame-to-buffer` results in incorrect frame position
> when the frame is not a child frame. I've looked into the code and
> seems that there are two issues: first is that frame monitor is
> ignored, always first monitor in `display-monitor-attributes-list` is
> used.

Good.  I never really checked that since I always use only one monitor.
Besides, 'frame-monitor-attributes' should be preferable anyway.

> Second is that `workarea` and `geometry` are in the form of `(X
> Y WIDTH HEIGHT)` but code treats them as `(X1 Y1 X2 Y2)`.

I believe the reasoning was to avoid moving the frame whenever it
already appears within its margins and thus constrain it to the region
to the right of and below (X, Y).  But my memory may fail.  Could you
provide an example where the original code results in bad placement?

> I'm
> providing a patch that fixes both issues.

Thanks, martin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]