[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Why are so many great packages not trying to get included in GNU Ema

From: Eli Zaretskii
Subject: Re: Why are so many great packages not trying to get included in GNU Emacs?
Date: Fri, 08 May 2020 09:26:12 +0300

> From: João Távora <address@hidden>
> Date: Thu, 7 May 2020 21:28:23 +0100
> Cc: ndame <address@hidden>, Yuan Fu <address@hidden>,
>  Emacs developers <address@hidden>, Dmitry Gutov <address@hidden>
>  I got confused by this part: why do you need the cookie?
> Because I changed the commit message: here's the commit I was 
> talking about earlier (from git.sv.gnu.org:/srv/git/emacs/elpa.git)
> commit 4953ee6f7de4ead0fced02e0da823eafaf5797e0
> Author: Ilya Ostapyshyn <address@hidden>
> Date:   Thu May 7 20:34:14 2020 +0300
>     Fix #13: correctly calculate search bound for narrowed buffers
>     The search-forward function does not take narrowing into account, so we 
> must
>     do that  ourselves.
>     Co-authored-by: João Távora <address@hidden>
>     Copyright-paperwork-exempt: yes
>     * darkroom.el (darkroom-guess-margins): Add (point-min) to the 20000
> I added all the commit message, but Ilya did the actual patch.
> Though reading Luke's email, it seems I could have use
> "Signed-off-by:" or something like that.

See CONTRIBUTE: we are asking not to use Signed-off-by.

As for Co-authored-by, this is IMO a borderline case: a change in the
commit log message does not necessarily mean you become a co-author.
But it doesn't do any harm, so it's your call whether to use it in
such cases.  I don't, FWIW.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]